Skip to content

buck2_server: Implement Git revision data#1346

Open
9999years wants to merge 1 commit into
facebook:mainfrom
MercuryTechnologies:wiggles/zltl
Open

buck2_server: Implement Git revision data#1346
9999years wants to merge 1 commit into
facebook:mainfrom
MercuryTechnologies:wiggles/zltl

Conversation

@9999years

Copy link
Copy Markdown
Contributor

What it says on the tin, closes a long-standing TODO and helps with our telemetry.

TODO: Should we just reuse the hg_revision field for Git revisions? They are also 40-character hashes...

What it says on the tin, closes a long-standing TODO and helps with our
telemetry.

TODO: Should we just reuse the `hg_revision` field for Git revisions?
They _are_ also 40-character hashes...
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 26, 2026
@meta-codesync

meta-codesync Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This pull request has been imported. If you are a Meta employee, you can view this in D109773248. (Because this pull request was imported automatically, there will not be any future comments.)

9999years added a commit to MercuryTechnologies/buck2 that referenced this pull request Jun 26, 2026
What it says on the tin, closes a long-standing TODO and helps with our
telemetry.

TODO: Should we just reuse the `hg_revision` field for Git revisions?
They _are_ also 40-character hashes...

Upstream:
- facebook#1346
9999years added a commit to MercuryTechnologies/buck2 that referenced this pull request Jun 26, 2026
What it says on the tin, closes a long-standing TODO and helps with our
telemetry.

TODO: Should we just reuse the `hg_revision` field for Git revisions?
They _are_ also 40-character hashes...

Upstream:
- facebook#1346
@9999years 9999years marked this pull request as ready for review June 26, 2026 00:45
9999years added a commit to MercuryTechnologies/buck2 that referenced this pull request Jun 26, 2026
What it says on the tin, closes a long-standing TODO and helps with our
telemetry.

TODO: Should we just reuse the `hg_revision` field for Git revisions?
They _are_ also 40-character hashes...

Upstream:
- facebook#1346
9999years added a commit to MercuryTechnologies/buck2 that referenced this pull request Jun 26, 2026
What it says on the tin, closes a long-standing TODO and helps with our
telemetry.

TODO: Should we just reuse the `hg_revision` field for Git revisions?
They _are_ also 40-character hashes...

Upstream:
- facebook#1346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant