This repository was archived by the owner on Nov 5, 2024. It is now read-only.
Squash exceptions when recovering from a disconnected COM port.#113
Open
SeanCline wants to merge 1 commit into
Open
Squash exceptions when recovering from a disconnected COM port.#113SeanCline wants to merge 1 commit into
SeanCline wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this awesome project! I've been using it for months now.
This change squashes the IOException that sometimes happens when calling
serialPort.close()on a COM port which no longer exists. This allows Adrilight to recover from USB disconnects more gracefully.Here's how that unhandled exception looks on my system:
My use-case might not be that common. My Teensy 3.0 is plugged into my monitor's USB port so it sees a lot of power cycles. Each time, I have to manually restart adrilight.exe. Not a big deal, but allowing Adrilight to recover from this situation solves a minor nuisance.