Repository navigation
Close sd.cpp feature gaps and polish settings UI - #11
Merged
Merged
Conversation
Backend correctness (verified against sd-cli master-820-de298c2): - Emit --model-args instead of the four --chroma-* / --qwen-image-zero-cond-t flags, which current sd.cpp no longer accepts. The old spelling is kept for binaries that still advertise it, chosen per-run from a capability probe. - Fix the SD3.5 pack's CLIP-G download, which 400ed because 'clipG' is not a model directory key. resolveModelDirectoryKey maps it to clip/. - Classify "unknown argument" failures instead of showing a generic error. runCli keeps the first error line before the usage dump evicts it. - Detect backend folders built for another OS (sd-cli.exe on Linux), which satisfied backendHasBinaries but could never run. - Extract parseCliHelp into a pure shared module with an exact-match hasHelpFlag, plus a server-side capability cache invalidated on backend switch. Refresh the checked-in help dumps and use them as a test fixture. Settings and setup UI: - Add an About panel with app version, build date, and runtime details, injected at build time from package.json. - Drop the pinned "recommended runtime" tag; the Installation panel now recommends the newest release and lists every published binary, labelled with OS and accelerator. - Show "None installed" rather than a phantom version when the stored backend is not on disk. - Restyle the setup wizard, add a way to skip the runtime download, and simplify the welcome and model steps. - Add an SD 1.5 starter pack (smallest) sourced from the sd.cpp docs. - Share one empty-state hero across the Image, Edit, and Video stages. - Keep the quantization output filename in sync with the target format. Tests: 104 -> 137.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend correctness (verified against sd-cli master-820-de298c2):
Settings and setup UI:
Tests: 104 -> 137.