fix: identify ECDSA algorithm for client keys from exec kubeconfig (#8022) - #8026
Open
arimu1 wants to merge 1 commit into
Open
fix: identify ECDSA algorithm for client keys from exec kubeconfig (#8022)#8026arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
…abric8io#8022) When a kubeconfig exec credential plugin returns client certificate/key data, set clientKeyAlgo via getKeyAlgorithm (same as static client-key entries). Without this, ECDSA keys left the algorithm unset and CertUtils defaulted to RSA, failing key load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8022
When a kubeconfig exec credential plugin returns client certificate and key data, the client was not setting
clientKeyAlgo. Staticclient-key-data/client-keyentries already rungetKeyAlgorithm(fixed in #3535), but the exec path only copied cert/key data.As a result, ECDSA keys from exec plugins left the algorithm unset,
CertUtils.loadKeydefaulted to RSA, and loading failed with:This change calls
config.setClientKeyAlgo(getKeyAlgorithm(null, config.getClientKeyData()))after applying exec-provided key material, matching the static kubeconfig path.Type of change
test, version modification, documentation, etc.)
Checklist
Test plan
ConfigTest#autoConfigure_whenExecReturnsEcdsaClientKey_thenSetClientKeyAlgoToEc(exec helper returns SEC1 ECDSA PEM; assertsclientKeyAlgo == "EC")ConfigTest(44 tests, 2 Windows-only skipped on macOS) — Temurin 21