Skip to content

BookingId mandatory for Messages - #50

Open
osarrat wants to merge 1 commit into
WIP-v1from
bookingMandatoryForMessages
Open

BookingId mandatory for Messages#50
osarrat wants to merge 1 commit into
WIP-v1from
bookingMandatoryForMessages

Conversation

@osarrat

@osarrat osarrat commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

While implementing the full API booking flow, we found out hard and counter-intuitive to leave open the sending of messages WITHOUT a Booking context.
As a consequence, we propose to :

  1. force to have all messages attached to Booking context (bookingId required in POST /messages) ;
  2. enable the sending of messages while creating a Booking (message optional attribute added in POST /bookings as it is already available in the PATCH /bookings endpoint) ;
  3. add an INITIATED bookingStatus (this bookingStatus is just used in the full API booking flow) to differenciate booking started just a casual chat and a formal booking request made by the passenger to the driver.

@adelcasse adelcasse left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants