Skip to content

Optimize range performance by limiting it based on available data #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laucheukhim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize range performance by limiting it based on available data #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/Range.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,14 @@ module.exports = function Range(str_expression, formula) {
sheet = formula.wb.Sheets[sheet_name];
var arr = range_expression.split(':');
var min_row = parseInt(arr[0].replace(/^[A-Z]+/, ''), 10) || 0;
var str_max_row = arr[1].replace(/^[A-Z]+/, '');
var max_row;
if (str_max_row === '' && sheet['!ref']) {
str_max_row = (sheet['!ref'].includes(':') ? sheet['!ref'].split(':')[1] : sheet['!ref']).replace(/^[A-Z]+/, '');
}
// the max is 1048576, but TLE
max_row = parseInt(str_max_row == '' ? '500000' : str_max_row, 10);
var range_max_row = parseInt(arr[1].replace(/^[A-Z]+/, ''), 10) || 500000;
var sheet_max_row = sheet['!ref'] && parseInt(
(sheet['!ref'].includes(':') ? sheet['!ref'].split(':')[1] : sheet['!ref'])
.replace(/^[A-Z]+/, ''),
10
) || 500000;
var max_row = range_max_row < sheet_max_row ? range_max_row : sheet_max_row;
var min_col = col_str_2_int(arr[0]);
var max_col = col_str_2_int(arr[1]);
return {
Expand Down