feat: add email/password registration by kazetani-SE · Pull Request #59 · f-code-club/rode-battle-api

kazetani-SE · 2026-05-08T07:25:08Z

akagiyuu · 2026-05-08T08:17:07Z

+		return "", fmt.Errorf("the email has been registerd")
+	}
+
+	hashPassword, err := HashPassword(password)


Rename hashPassword to hashedPassword

patohru · 2026-05-08T08:52:21Z

+	id, err := queries.CreateAccount(ctx, database.CreateAccountParams{
+		Email:    email,
+		Password: hashPassword,
+		Name:     name,
+	})


After generate new sqlc add following there I just mention

akagiyuu · 2026-05-08T09:10:49Z

+		panic(err)
+	}
+
+	authService := auth.NewAuthService(pool)


Move auth service init to internal/http/server

AnataAria · 2026-05-08T12:39:56Z

Let's move it to internal/config

AnataAria · 2026-05-08T12:45:12Z

+func (s *AuthService) Register(ctx context.Context, email string, password string, name string) (string, error) {
+	queries := database.New(s.Pool)
+
+	_, err := queries.GetAccountByEmail(ctx, email)


In here we should need a context timeout here, set the timeout for about 5 secs

AnataAria · 2026-05-08T12:46:36Z

+		return "", fmt.Errorf("can not create new account")
+	}
+
+	return id.String(), nil


Drop string and return nil only, nil error mean the func is work as expected

AnataAria · 2026-05-08T13:00:31Z

+	queries := database.New(s.Pool)
+
+	_, err := queries.GetAccountByEmail(ctx, email)
+	if err == nil {


Why u use an err to believe that when an error happen during query, 100% is email is existed ?

akagiyuu · 2026-05-14T01:14:25Z

+	ctx, cancel := context.WithTimeout(ctx, defaultTimeout)
+	defer cancel()


you should use the ctx in the parameter instead. fuego will automatically handle timeout,... for you (that ctx will have request scope, and live until request end or cancelled)

I don't remember fuego handle timeout like that, it handle timeout from net/http like read, write and doesn't have cancel like WithTimeout. But I think he's already use ctx from the params no?

akagiyuu · 2026-05-15T12:53:24Z

+	"github.com/go-playground/validator/v10"
+)
+
+func Init() (*validator.Validate, error) {


rename to NewValidator

feat: add email/password registration

b03377f

kazetani-SE requested review from AnataAria and akagiyuu May 8, 2026 07:25

kazetani-SE force-pushed the feat/email-password-register branch from 39b25f2 to 46be641 Compare May 8, 2026 07:33

fix lint errors

ec4d7e3

kazetani-SE force-pushed the feat/email-password-register branch from 46be641 to ec4d7e3 Compare May 8, 2026 07:37

kazetani-SE linked an issue May 8, 2026 that may be closed by this pull request

Implement email/password registration #4

Closed

akagiyuu requested changes May 8, 2026

View reviewed changes

Comment thread internal/http/auth.handler.go Outdated

akagiyuu requested a review from patohru May 8, 2026 08:45

patohru requested changes May 8, 2026

View reviewed changes

fix(database): move DATABASE_URL env read to config

44768bb

akagiyuu reviewed May 8, 2026

View reviewed changes