Watermark images could be in any extension - #20
Open
eab-andy wants to merge 4 commits into
Open
Conversation
Mimic the ezimage() template operator and find a file that matches the given image name.
Contributor
There was a problem hiding this comment.
cs
should be the following according to ez v1 coding standard used in legacy:
if ( !$fileInfo )
{
Contributor
|
+1 |
Author
|
Updated. |
Contributor
|
looks good, just one more cs comment open, I updated it to specify what I implied, up for it before we go ahead and create issue + squash and update commit messages + merge? |
Follow coding standard for eZ Publish legacy
Author
|
Thanks for clarifying that. I've edited again. |
Contributor
|
Ok, looks ok. remain part is create an issue, rebase the branch to squash commits into one referring to the issue and force push and you should be done :) something like git rebase -i master
# a interactive screen will allow you to put a 's' in front of each line but the first one
git push eab-dev WatermarkSubfolders -f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mimic the ezimage() template operator and find a file that matches the given image name.
Without this PR, you can only store watermarks inside the ezie extension.