Watermarks in extension - #12
Open
bchoquet-heliopsis wants to merge 4 commits into
Open
Conversation
…zeta components issue ZETACOMP-55
Contributor
There was a problem hiding this comment.
Wouldn't it be better to use eZURLOperator::eZImage() to get the path of the file, thus allowing overriding images in custom designs? There would be no need for WatermarkExtensions setting at all, just put the images in watermarks directory in any of designs in any of extensions?
Contributor
Author
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
watermarks were to be put only in ezie extension, this patch allows to define other extensions as watermark repositories.
Also, watermark filter do not work properly with eZComponents (see https://issues.apache.org/jira/browse/ZETACOMP-55) so I took the liberty to override
watermarkAbsolute()in the dedicated ezie image magick handler