Skip to content

Reset TEXT dict for parsing next dataset#77

Open
machichima wants to merge 1 commit into
eyurtsev:masterfrom
machichima:multi-dataset-clear-anno
Open

Reset TEXT dict for parsing next dataset#77
machichima wants to merge 1 commit into
eyurtsev:masterfrom
machichima:multi-dataset-clear-anno

Conversation

@machichima

Copy link
Copy Markdown

While parsing the fcs file with multiple datasets in it, I discover that the TET value from the first dataset will persist to the next dataset. For example, my first dataset's TEXT include $FIL but the second does not. However, when using fcsparser.parse(..., data_set=1), I found the metadata output from this contains $FIL, which shouldn't.

In this PR I reset the metadata dict when starting parsing the new dataset

@eyurtsev

Copy link
Copy Markdown
Owner

Could you include a test file?

@machichima

Copy link
Copy Markdown
Author

Hi @eyurtsev ,

Thanks for the reply! Below is our test file. You can see two datasets in this file, one for FCS2.0 and the other for FCS3.0. You may have a look at @RATIO_NUMERATOR for example, which exists in FCS2.0 dataset but not in FCS3.0 one.

000035.fcs.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants