Reset TEXT dict for parsing next dataset#77
Open
machichima wants to merge 1 commit into
Open
Conversation
Owner
|
Could you include a test file? |
Author
|
Hi @eyurtsev , Thanks for the reply! Below is our test file. You can see two datasets in this file, one for FCS2.0 and the other for FCS3.0. You may have a look at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While parsing the fcs file with multiple datasets in it, I discover that the TET value from the first dataset will persist to the next dataset. For example, my first dataset's TEXT include
$FILbut the second does not. However, when usingfcsparser.parse(..., data_set=1), I found the metadata output from this contains$FIL, which shouldn't.In this PR I reset the metadata dict when starting parsing the new dataset