fix: add .gitattributes to prevent CRLF corruption of test fixtures on Windows#1415
Open
UjjwalKumar239 wants to merge 1 commit into
Open
fix: add .gitattributes to prevent CRLF corruption of test fixtures on Windows#1415UjjwalKumar239 wants to merge 1 commit into
UjjwalKumar239 wants to merge 1 commit into
Conversation
…n Windows Test fixture .dat files were being corrupted by Windows CRLF line ending conversion, causing file size mismatches (1778 vs 1803 bytes). Also fixed a hardcoded Unix path separator in functionality.js test assertion. Fixes test failures on Windows for: - Disk Storage tests - Memory Storage tests - Reuse Middleware tests - Select Field tests - Functionality tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, Git's automatic CRLF line ending conversion corrupts binary
test fixture files (.dat), causing 12 test failures due to file size
mismatches (expected 1778 bytes, got 1803 bytes — a difference of 25 bytes
matching exactly 25
\rcharacters added by Windows).Fix
.gitattributesmarkingtest/files/*.datandtest/files/*.jpgas binary to prevent line ending conversion on any OS
/testforme-→testforme-intest/functionality.jsfor cross-platform compatibilityTesting
All 72 tests now pass on Windows.