Fix multipart boundaries containing equals signs#1400
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1051.
Multer used
type-isto detect multipart requests before handing the request to Busboy.type-isrejects unquoted multipart boundary parameters containing=, even though those boundaries can be parsed by the multipart stream itself. The result was that Multer skipped the request entirely.This changes the early multipart check to avoid parsing parameters and only inspect the media type while still honoring
type-is.hasBody(req). Before constructing Busboy, it normalizes only unquoted boundary values containing=by quoting the boundary in the headers passed to Busboy. The original request headers are not mutated.Validation:
npx mocha --reporter spec --exit --check-leaks test/fields.jsnpm run lintnpm testwas also run; it still fails on existing Windows fixture-size/path assertions unrelated to this change, while the new fields regression passed.