Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions lib/request.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ req.header = function header(name) {
switch (lc) {
case 'referer':
case 'referrer':
return this.headers.referrer
|| this.headers.referer;
return getHeader(this.headers, 'referrer')
|| getHeader(this.headers, 'referer');
default:
return this.headers[lc];
return getHeader(this.headers, lc);
}
};

Expand Down Expand Up @@ -525,3 +525,26 @@ function defineGetter(obj, name, getter) {
get: getter
});
}

/**
* Get a header value with case-insensitive matching.
*
* @param {Object} headers
* @param {String} name
* @return {String}
* @private
*/

function getHeader(headers, name) {
var value = headers[name];

if (value !== undefined) {
return value;
}

for (var key in headers) {
if (key.toLowerCase() === name) {
return headers[key];
}
}
}
17 changes: 17 additions & 0 deletions test/req.get.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,23 @@ describe('req', function(){
.expect('application/json', done);
})

it('should return header field value set with non-lowercase key', function (done) {
var app = express()

app.use(function (req, res, next) {
req.headers['X-Filipe'] = 'filipe'
next()
})

app.use(function (req, res) {
res.end(req.get('x-filipe'))
})

request(app)
.get('/')
.expect('filipe', done)
})

it('should special-case Referer', function(done){
var app = express();

Expand Down