docs: warn against combining origin: true with credentials: true#423
Open
AchieverSana wants to merge 1 commit into
Open
docs: warn against combining origin: true with credentials: true#423AchieverSana wants to merge 1 commit into
AchieverSana wants to merge 1 commit into
Conversation
Adds a note near the configuration options warning that origin: true + credentials: true allows any origin to make credentialed requests, since origin: true reflects the request's Origin header rather than restricting it. Closes expressjs#422
Author
|
Hi! This adds a warning for the origin: true + credentials: true combination that's a common security footgun. Happy to adjust the wording if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a note near the configuration options warning that origin: true + credentials: true allows any origin to make credentialed requests, since origin: true reflects the request's Origin header rather than restricting it. Closes #422