Skip to content

Skip compression for partial content responses #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vibhor-aggr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip compression for partial content responses #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,12 @@ function compression (options) {
return
}

// response is partial content
if (res.statusCode === 206) {
nocompress('partial content')
return
}

// vary
vary(res, 'Accept-Encoding')

Expand Down
19 changes: 19 additions & 0 deletions test/compression.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,25 @@ describe('compression()', function () {
.expect(200, 'hello, world', done)
})

it('should skip partial content responses', function (done) {
var server = createServer({ threshold: 0 }, function (req, res) {
res.statusCode = 206
res.setHeader('Content-Type', 'text/plain')
res.setHeader('Content-Range', 'bytes 0-4/12')
res.setHeader('Content-Length', '5')
res.end('hello')
})

request(server)
.get('/')
.set('Accept-Encoding', 'gzip')
.set('Range', 'bytes=0-4')
.expect(shouldNotHaveHeader('Content-Encoding'))
.expect('Content-Range', 'bytes 0-4/12')
.expect('Content-Length', '5')
.expect(206, 'hello', done)
})

it('should set Vary', function (done) {
var server = createServer({ threshold: 0 }, function (req, res) {
res.setHeader('Content-Type', 'text/plain')
Expand Down