Skip to content

refactor(snackager): rotate secrets and use proper access token for git imports #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
byCedric wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(snackager): rotate secrets and use proper access token for git imports #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion snackager/.env-cmdrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module.exports = (async function () {

delete stagingSecrets['REDIS_URL']; // this is set above for the proxy

if (!stagingSecrets.GIT_SESSION_SECRET && !processArgs.includes('env-cmd -e test')) {
if (!stagingSecrets.EXPO_GIT_TOKEN && !processArgs.includes('env-cmd -e test')) {
console.error(
'Secrets are locked, unable to start Snackager. External contributors cannot start Snackager and can ignore this error. snack-proxies will redirect traffic to the Snackager service running on the staging environment.\n'
);
Expand Down
Binary file modified snackager/k8s/production/secrets/snackager.env
View file
Open in desktop
Binary file not shown.
Binary file modified snackager/k8s/staging/secrets/snackager.env
View file
Open in desktop
Binary file not shown.
4 changes: 3 additions & 1 deletion snackager/src/git.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ export async function importAsync(options: Config): Promise<string> {
sdkVersion,
name,
description,
user: { sessionSecret: process.env.GIT_SESSION_SECRET },
user: {
accessToken: process.env.EXPO_GIT_TOKEN,
},
});

logger.info(options, 'saving repository');
Expand Down