[eas-cli] Connect existing PostHog accounts via browser handoff#3895
Open
gwdp wants to merge 1 commit into
Open
[eas-cli] Connect existing PostHog accounts via browser handoff#3895gwdp wants to merge 1 commit into
gwdp wants to merge 1 commit into
Conversation
99196eb to
563d9a2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3895 +/- ##
==========================================
+ Coverage 59.05% 59.11% +0.06%
==========================================
Files 935 935
Lines 40959 41019 +60
Branches 8630 8643 +13
==========================================
+ Hits 24185 24244 +59
- Misses 16678 16679 +1
Partials 96 96 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
336b80f to
0b4567e
Compare
0b4567e to
cb15ee2
Compare
|
✅ Thank you for adding the changelog entry! |
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Existing PostHog users couldn't connect —
eas integrations:posthog:connectdead-ended with a "not supported yet" message when the account's email already had a PostHog account.How
On the existing-user (
requires_auth) branch, open the approval URL in the browser, poll for the connection the website callback creates, then continue with the rest ofconnect. Non-interactive runs refuse with a clear message instead of hanging. Pairs with theuniversestack (thestartPostHogConnection/completePostHogConnectionmutations + the/posthog/callbackwebsite scene).Test Plan
yarn test connect(added: browser handoff opens the URL + polls, non-interactive refusal, poll timeout).connectwith an email that already has a PostHog account, approve in the browser, confirm it links and continues.