Conversation
doorgan
force-pushed
the
doorgan/manager-indexing
branch
3 times, most recently
from
September 24, 2026 17:08
5f65bc1 to
fbbe109
Compare
doorgan
marked this pull request as ready for review
September 24, 2026 17:26
Contributor
Author
|
cc @katafrakt, this may also help with the memory issues you were seeing |
doorgan
force-pushed
the
doorgan/manager-indexing
branch
from
September 27, 2026 13:44
fbbe109 to
397bd8a
Compare
doorgan
added this pull request to stack #909
September 27, 2026 15:31
doorgan
force-pushed
the
doorgan/manager-indexing
branch
2 times, most recently
from
September 27, 2026 19:58
004da3d to
01c5e34
Compare
doorgan
force-pushed
the
doorgan/manager-indexing
branch
from
September 27, 2026 20:35
01c5e34 to
39888fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at the possibility of indexing without the engine and realized there are not many reasons to keep the indexer in the engine. A smaller benefit but still part of the motivation is that on the fly engine builds can be a little bit faster and take a little bit less disk space it less code needs to be compiled.
This PR moves the indexer to the manager node, and changes a few things about how the indexer works. It's a big change because all indexer files are moved to the manager node, so I tried to split this into several commits that touch each individual step I took to implement this so it's easier to review.
Total time to perform a full reindex of Sequin is a little bit faster with this vs main(7 seconds with this, closer to 10 seconds with main). Memory usage is way less and more stable though, which is the main benefit of this change.