fix(nix): only expose the expert launcher - #899
Merged
Merged
Conversation
doorgan
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes
start_expertfrom the nix package before fixup wraps the executables. that script callsbin/plain, which the nix derivation renames tobin/expert, so exposing it gives users a broken entry point. plain/source builds keep their existing launcher.adds an install check that only
expertis public inbinand is executable. hidden nix wrapper files are left intact.validation with the locked nixpkgs revision, Nix 2.35.2 in a Linux ARM64 container:
nix build .#expert --no-link --print-out-paths --option sandbox false— passed, including the install checknixfmt --check nix/expert.nix— passedgit diff --check— passedstart_expert --helpexited 127 becausebin/plainwas missing; after the fix, onlyexpertis exposedseparate runtime observation:
expert --helpentered an Erlang shell on both the pre-fix and patched packages in this container, so i'm not claiming a successful CLI smoke test. this PR only changes the exported launcher set.closes #429