#292 serve build: return 404 on missing .map requests instead of try to render as HTML - #294
Open
d9k wants to merge 1 commit into
Open
#292 serve build: return 404 on missing .map requests instead of try to render as HTML#294d9k wants to merge 1 commit into
d9k wants to merge 1 commit into
Conversation
…uests instead of try to render as HTML
Danielduel
approved these changes
Jan 13, 2024
Danielduel
left a comment
Danielduel
left a comment
There was a problem hiding this comment.
lgtm, kinda weird that you are using "regex" instead of /regex/ - I haven't seen regexes as strings like this before.
Also - you could move this regex to serveStatic's top closure so it's created once and preserved in memory instead of recreating regex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#292