Skip to content

Update GHA workflow versions: Node LTS=24, active=22,24; Ubuntu 26.04 #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IsaacG wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update GHA workflow versions: Node LTS=24, active=22,24; Ubuntu 26.04 #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ on:

jobs:
precheck:
runs-on: ubuntu-24.04
runs-on: ubuntu-26.04

steps:
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5
- name: Use Node.js LTS (16.x)
- name: Use Node.js LTS (24.x)
uses: actions/setup-node@v1
with:
node-version: 16.x
node-version: 24.x

- name: Install project dependencies
run: yarn install --frozen-lockfile --ignore-scripts
Expand All @@ -25,11 +25,11 @@ jobs:
run: yarn lint

unit_tests:
runs-on: ubuntu-24.04
runs-on: ubuntu-26.04

strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [24.x, 26.x]

steps:
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5
Expand All @@ -48,7 +48,7 @@ jobs:
run: yarn test:e2e

smoke_tests:
runs-on: ubuntu-24.04
runs-on: ubuntu-26.04
steps:
- name: Checkout code
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/pr.ci.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,29 +7,29 @@ on: pull_request

jobs:
precheck:
runs-on: ubuntu-24.04
runs-on: ubuntu-26.04

steps:
- name: Checkout PR
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5

- name: Use Node.js LTS (16.x)
- name: Use Node.js LTS (24.x)
uses: actions/setup-node@v1
with:
node-version: 16.x
node-version: 24.x

- name: Install project dependencies
run: yarn install --frozen-lockfile --ignore-scripts

- name: Run exercism/javascript ci precheck (lint code)
run: yarn lint

unit_tests:
runs-on: ubuntu-24.04
ci:
runs-on: ubuntu-26.04

strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [24.x, 26.x]

steps:
- name: Checkout PR
Expand All @@ -50,7 +50,7 @@ jobs:
run: yarn test:e2e

smoke_tests:
runs-on: ubuntu-24.04
runs-on: ubuntu-26.04
steps:
- name: Checkout code
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
Expand Down
5 changes: 3 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
FROM node:lts-alpine3.23@sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f AS builder
# sha256:a0b9bf06e4e6193cf7a0f58816cc935ff8c2a908f81e6f1a95432d679c54fbfd => node:24.18.0-alpine3.24
FROM node:lts-alpine@sha256:a0b9bf06e4e6193cf7a0f58816cc935ff8c2a908f81e6f1a95432d679c54fbfd AS builder

# Install SSL ca certificates
RUN apk update && apk add ca-certificates
Expand All @@ -17,7 +18,7 @@ RUN yarn install
RUN yarn install --production --modules-folder './production_node_modules'

# Build a minimal and secured container
FROM node:lts-alpine3.23@sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f
FROM node:lts-alpine@sha256:a0b9bf06e4e6193cf7a0f58816cc935ff8c2a908f81e6f1a95432d679c54fbfd
COPY --from=builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/
COPY --from=builder /etc/passwd /etc/passwd
COPY --from=builder /javascript-analyzer/package.json /opt/analyzer/package.json
Expand Down
Loading