Raise dev container upload limits to 1G for large .elpx packages - #113
Merged
Conversation
The erseco/alpine-moodle dev container was rejecting uploads of large .elpx packages. Add upload_max_filesize alongside the existing client_max_body_size and post_max_size so the three PHP/nginx limits agree at 1G. Development environment only.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=========================================
Coverage 92.31% 92.31%
Complexity 824 824
=========================================
Files 51 51
Lines 3734 3734
=========================================
Hits 3447 3447
Misses 287 287
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The development container (
erseco/alpine-moodle, used bydocker-compose.yml)was rejecting uploads of large
.elpxcourse packages. Moodle's file pickerupload only succeeds when nginx's
client_max_body_sizeand PHP'spost_max_size/upload_max_filesizeall agree on a limit high enough forthe package being uploaded.
Why 1G
client_max_body_sizeandpost_max_sizewere already set to1Gfor themoodleservice.upload_max_filesizewas still at its container default,which is lower than
post_max_sizeand silently truncates/rejects theupload before PHP even gets to enforce
post_max_size. Setting all three tothe same
1Gvalue removes that mismatch and gives enough headroom for the.elpxpackages used in manual testing and demos.Scope
Development environment only (
docker-compose.yml,moodleserviceenvironmentblock). No production code, plugin logic, or CI configurationis touched.
Validated with
docker compose config; a real upload >50M is recommended after merge (reviewer suggestion).Moodle Playground Preview
The changes in this pull request can be previewed and tested using a Moodle Playground instance.
ℹ️ The eXeLearning editor is fetched from the shared release and unpacked into the plugin when the playground boots, so the first load may take a few extra seconds. ELPX upload, viewer and preview work normally.