Skip to content

Use RGBA16F for feedback texrenders to fix 8-bit precision loss in self-feedback shaders #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
h-e-d-o-n wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use RGBA16F for feedback texrenders to fix 8-bit precision loss in self-feedback shaders #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion obs-shaderfilter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2869,7 +2869,14 @@ static void shader_filter_tick(void *data, float seconds)
gs_texrender_t *create_or_reset_texrender(gs_texrender_t *render)
{
if (!render) {
render = gs_texrender_create(GS_RGBA, GS_ZS_NONE);
// Use a 16-bit float format rather than 8-bit RGBA so that shaders
// which feed a texrender's output back into itself as
// previous_image/previous_output (e.g. accumulating or decaying a
// value by a small fraction each frame) don't get stuck at an 8-bit
// UNORM rounding fixed point. This matches the format libobs
// already prefers for HDR/extended color spaces elsewhere in this
// file (see gs_get_format_from_space() below).
render = gs_texrender_create(GS_RGBA16F, GS_ZS_NONE);
} else {
gs_texrender_reset(render);
}
Expand Down