fix(gui): rank checkbox overlapped the DOCX/output-format row#14
Merged
Conversation
The "Sort by relevance" checkbox (slice 3) was gridded at cb_frame row 3, col 0 — but formats_row (DOCX/CSV/JSON/PDF/HTML) already occupied row 3 (columnspan=3). They overlaid each other: the DOCX checkbox appeared to sit on top of something, and the rank checkbox wasn't visible as a distinct control. Fix: move formats_row to row 4; rank keeps its own row 3 (cb_frame rows are now 0 and/rec/fuzzy, 1 wild/regex/ocr, 2 inverse/expr/whole-word, 3 rank, 4 output-formats). No behavior change; layout only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Robert D. Schoening <bobschoening@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug (reported from the live GUI)
The "Sort by relevance" checkbox (ranking slice 3) was gridded at
cb_framerow 3, col 0 — butformats_row(the DOCX/CSV/JSON/PDF/HTML checkboxes) already occupied row 3 (columnspan=3). They overlaid each other: the DOCX checkbox appeared to sit on top of something, and the rank checkbox wasn't visible as a distinct control. Both symptoms, one cause.Fix
Move
formats_rowto row 4; rank keeps its own row 3.cb_framerows are now:Layout only — no behavior change.
Note
CI can't verify GUI layout (no display), so this needs a manual eyeball in the running GUI — but tests + mypy + import are green, and the grid rows no longer collide.
🤖 Generated with Claude Code