⚡ perf: optimize estimateImageTokensFromMeta loop - #13
Conversation
Co-authored-by: exalsch <170920995+exalsch@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: exalsch <170920995+exalsch@users.noreply.github.com>
Co-authored-by: exalsch <170920995+exalsch@users.noreply.github.com>
Co-authored-by: exalsch <170920995+exalsch@users.noreply.github.com>
💡 What: Replaced the
for...ofloop inestimateImageTokensFromMetawith a classicforloop (caching the length), and replaced optional chaining with direct boolean checks (m && m.width).🎯 Why: To optimize the token estimation inner loop. Iterating with
for...ofcreates an iterator object allocation on each call, and optional chaining/as anyadds minor unnecessary transpilation overhead.📊 Measured Improvement:
I created a benchmark file testing
estimateImageTokensFromMetawith an array of 30,000 metadata objects, simulating heavy image inputs, running 10,000 loop executions per run.PR created automatically by Jules for task 16929286264939332144 started by @exalsch