Skip to content

Add synchronous execution to TaskSubmitter#340

Merged
t20100 merged 3 commits into
mainfrom
task-submitter-synchronous
Jul 6, 2026
Merged

Add synchronous execution to TaskSubmitter#340
t20100 merged 3 commits into
mainfrom
task-submitter-synchronous

Conversation

@t20100

@t20100 t20100 commented Jul 2, 2026

Copy link
Copy Markdown
Member

! Merge PR #334 first!

This PR adds a "synchronous" execution mode to TaskSubmitter as suggested in #334 (comment)

See commit 61b7e5e

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ewoksjob/client/task_utils.py 83.87% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@t20100 t20100 force-pushed the task-submitter-synchronous branch from 61b7e5e to 49eae81 Compare July 2, 2026 15:10
@t20100 t20100 marked this pull request as ready for review July 2, 2026 15:12
@t20100 t20100 requested a review from a team July 2, 2026 15:12
@t20100 t20100 force-pushed the task-submitter-synchronous branch from 49eae81 to 92203b8 Compare July 2, 2026 15:15

@woutdenolf woutdenolf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I forgot we need to handle the absence of ewoks. Pure clients (pip install ewoksjob) can only execute remote.

Comment thread src/ewoksjob/client/task_utils.py Outdated

@woutdenolf woutdenolf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@t20100 t20100 merged commit cb8e2b1 into main Jul 6, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants