Skip to content

raise an error when the configuration from EWOKS_CONFIG_URI is empty#337

Merged
woutdenolf merged 3 commits into
mainfrom
336-raise-error-when-ewoks_config_uri-is-provided-but-has-a-syntax-error
Jun 30, 2026
Merged

raise an error when the configuration from EWOKS_CONFIG_URI is empty#337
woutdenolf merged 3 commits into
mainfrom
336-raise-error-when-ewoks_config_uri-is-provided-but-has-a-syntax-error

Conversation

@woutdenolf

@woutdenolf woutdenolf commented Jun 24, 2026

Copy link
Copy Markdown
Member

We were struggling yesterday with the celery configuration because this is not a syntax error in python (type annotations):

broker_url: f"sqla+sqlite:///celery.db"
result_backend: f"db+sqlite:///celery_results.db"

Solution: raise when config has no global variables.

@woutdenolf woutdenolf requested a review from LudoBroche June 24, 2026 05:44
@woutdenolf woutdenolf linked an issue Jun 24, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ewoksjob/config.py 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@woutdenolf woutdenolf force-pushed the 336-raise-error-when-ewoks_config_uri-is-provided-but-has-a-syntax-error branch 2 times, most recently from 0615941 to 8bf0831 Compare June 24, 2026 06:35
@woutdenolf woutdenolf force-pushed the 336-raise-error-when-ewoks_config_uri-is-provided-but-has-a-syntax-error branch from 8bf0831 to b367a56 Compare June 24, 2026 06:39
@woutdenolf woutdenolf requested a review from olofsvensson June 24, 2026 06:51
@woutdenolf

Copy link
Copy Markdown
Member Author

CI needed fixing as well. It was reported upstream: redis/redis-om-python#833.

@woutdenolf

Copy link
Copy Markdown
Member Author

I merge. I need the fix in the CI.

@woutdenolf woutdenolf merged commit f056755 into main Jun 30, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raise error when EWOKS_CONFIG_URI is provided but has a syntax error

1 participant