Repository navigation
Add Popfeed shelves for books, games and albums - #53
Merged
Merged
Conversation
The homepage only showed films and TV from Popfeed reviews. Reviews are now grouped into Watching, Reading, Playing and Listening shelves, and a shelf is hidden when it has no entries. - Replace watching.ts with popfeed.ts, which fetches all reviews once - Add popfeedShelves.ts for the pure grouping logic, with unit tests - Add test:popfeed script and run it in CI - Render every shelf through one snippet on the homepage Book, game and album creativeWorkType values are unverified against the live Popfeed lexicon; unknown types simply do not appear. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KqNMDvAYUtTqRWMg6ye1uZ
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…lves Popfeed records games as "video_game", not "game", so the Playing shelf could never show anything. The bridge README for neodb-social/skybridge lists the values in use; the Listening shelf also takes "ep" and "music", and the Watching shelf takes "tv_season". Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KqNMDvAYUtTqRWMg6ye1uZ
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The homepage only showed films and TV from Popfeed reviews. Reviews are
now grouped into Watching, Reading, Playing and Listening shelves, and a
shelf is hidden when it has no entries.
Book, game and album creativeWorkType values are unverified against the
live Popfeed lexicon; unknown types simply do not appear.
Co-Authored-By: Claude Haiku 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01KqNMDvAYUtTqRWMg6ye1uZ