Repository navigation
Conversation
Five handlers in sync_routes.c repeated the 400 InvalidRequest "<name> is required" guard. They now call require_string from the shared src/route_params.h. Rendered messages are unchanged (compared as a multiset, 9 before and 9 after). The other four messages in the file use different checks and are left alone. Refs #89 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Owner
Author
|
Replaced by #112 (branch renamed to type/slug so the flow / conventions check passes). Same commits and content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #89 (the
sync_routes.cpart). Depends on thesrc/route_params.hheader, which is also in #101; the two PRs add the identical file.What this changes
src/route_params.h:require_string, the shared guard for required string parameters.src/sync/sync_routes.c: five handlers now callrequire_string.src/admin/admin_routes.c(in refactor(admin): one check for required string parameters #101) uses the same header.Verification
ctest: 46/46 pass.Not covered:
repo_routes.c, the account registry.Docs
None needed: internal refactor with no user-facing behaviour, config or API change.
Changelog: none — internal refactor, no behaviour change.
🤖 Generated with Claude Code