Repository navigation
Conversation
proxy_appview and proxy_fallback each resolved the upstream, built the target URL and minted service-auth from the account's repo key. Both now use appview_prepare_target and mint_service_auth. The differing checks stay where they were: the read-after-write splice and Bearer verification. Behaviour is unchanged; ctest is 46/46. Refs #89 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Owner
Author
|
Replaced by #110 (branch renamed to type/slug so the flow / conventions check passes). Same commits and content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #89 (route helpers, the appview part).
What this changes
src/appview/appview_routes.c:proxy_appviewandproxy_fallbackrepeated the upstream resolution, target-URL build and service-auth minting. They now shareappview_prepare_targetandmint_service_auth. The differing logic stays put: the read-after-write splice inproxy_appview, and Bearer verification in the fallback.Verification
ctest: 46/46 pass; no new warnings from this file.Still open under #89: the admin, sync and repo route files and the account registry.
Docs
None needed: internal refactor with no user-facing behaviour, config or API change.
Changelog: none — internal refactor, no behaviour change.
🤖 Generated with Claude Code