Repository navigation
feat(app): list the camera folder in the image picker - #74
Merged
Merged
Conversation
The picker listed only sdmc:/3ds/indigo/images. The 3DS camera saves photos as sdmc:/DCIM/<folder>/<image>, so the picker now also lists the images one folder down in sdmc:/DCIM, after the app folder's own. Each camera row is marked, and choosing one attaches its full path. The app folder scan is unchanged. The top screen names both folders. The camera scan uses Wolfram's wf_attach_scan_images_tree, which needs Wolfram v0.39.0 (not released yet). The pin stays at v0.38.0 on main. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The attach picker listed only
sdmc:/3ds/indigo/images. The 3DS camera saves photos assdmc:/DCIM/<folder>/<image>, so the picker now also lists the images one folder down insdmc:/DCIM, after the app folder's own entries.wf_attach_scan_images_tree(rows arenameorfolder/name). The app folder keepswf_attach_scan_images, unchanged.cameraflag on the menu item. Choosing one setscompose.imagetosdmc:/DCIM/<folder>/<image>; app-folder rows are unchanged.indigo_menu_build_imagestakes the camera folder;app.camera_diris the test seam, asapp.images_diralready is.docs/PARITY.mdrecords the decision that was open before.Dependency: this PR needs Wolfram v0.39.0 released first.
wf_attach_scan_images_treeis onewanc26/wolframPR #193 (branchfeat/attach-camera-folder) and is not in any release.wolfram.refstays at v0.38.0 on main in this PR, so the 3DS CI job may be red until the pin moves to v0.39.0. That is expected. Do not merge until v0.39.0 is out and the pin is bumped.Limit: the camera scan takes the first matching files in directory order, up to the picker's 23 rows, so a camera folder with many more photos than that shows only some of them.
Verification
make test, withWOLFRAM_ROOTat Wolfram1c75415, built for host): 4065 checks, 0 failures. The newtest_attach_camera_foldercovers the camera rows' labels and flags, the order (app folder first), that a non-image file is skipped, and that choosing a camera row attaches its full path.make warnings): clean.make snapshots):attach-pickerdrawn and read. The top screen shows both folders and the paragraph fits. Host only.make, Wolfram1c75415built withmake wolfram-3ds): linksindigo.3dsx.Docs
CHANGELOG.md: an Added entry under[Unreleased].docs/PARITY.md: the picker row now coverssdmc:/DCIM, and the open "is it undecided" note is replaced by the decision.AGENTS.md: no change needed; it does not describe the picker's folders.Changelog: CHANGELOG.md
Checklist
CI gateandflow / conventions) — not yet: the 3DS job needs the Wolfram v0.39.0 pin🤖 Generated with Claude Code