Repository navigation
feat(media): video embeds show their poster, not a bare note - #69
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A video embed shows its poster frame, decoded at the size it is drawn (400 px at most), with a line saying it cannot play on the 3DS. Part of #22; the poster is drawn, the video is not.
The poster and its aspect ratio come from Wolfram v0.37.0 (
wf_post_embed).wolfram.refmoves to v0.37.0.Verification
Host:
make test4035 checks, 0 failures;make warningsclean. The poster and its label are checked not to overlap intest_layout_draws_video_poster. Not run on a 3DS or in Azahar.Docs
PARITY row updated; CHANGELOG entry added.
Changelog: CHANGELOG.md
Checklist
CI gateandflow / conventions)🤖 Generated with Claude Code