Skip to content

refactor(session): split the 2,500-line session by what a job is about #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ewanc26 merged 1 commit into from
Oct 7, 2026
Merged

refactor(session): split the 2,500-line session by what a job is about #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ src/
├── gfx/ platform-neutral display lists (canvas)
├── ui/ layout.c (pure) and ui.c (citro2d/citro3d backend)
├── input/ 3DS buttons, sticks and touchscreen
├── atproto/ Wolfram-backed integration; session.c runs login on a worker thread, prefs.c is the pure muted-word matching
├── atproto/ Wolfram-backed integration; session.c is the worker thread and its queue and the `session_*.c` files beside it hold the jobs (auth, view, read, people, lists, write; `session_internal.h` is what they share, `session_stub.c` stands in without a 3DS build of Wolfram), prefs.c is the pure muted-word matching
├── store/ session and settings codecs, atomic stores on sdmc
└── util/ logging (file + stderr) and small helpers

Expand Down Expand Up @@ -632,7 +632,7 @@ Watch for:
- believing `make warnings` covers `tools/snapshot.c`. It builds only `src/`
and `tests/`, so a snapshot scenario that does not compile is caught by
`make snapshots` alone;
- believing the host targets cover `src/atproto/session.c`. Its Wolfram calls all sit behind `#if defined(__3DS__)`, so `make test`, `make warnings` and `make snapshots` compile none of them. A wrong Wolfram signature, a missing include or an undeclared static has passed all three and failed only the cross-build, five times now: `wf_display_facet`, a missing `<limits.h>` for `UINT_MAX`, `wf_agent_get_author_feed_typed`'s `filter` argument, `s_account` (a static that never existed; the agent's own handle comes from `wf_agent_get_handle`), and a missing `<wolfram/feed_gen_typed.h>` for `wf_feedgen_get_feed_generators_typed`. Run `make` for the console before calling a session change done;
- believing the host targets cover `src/atproto/session*.c`. Its Wolfram calls all sit behind `#if defined(__3DS__)`, so `make test`, `make warnings` and `make snapshots` compile none of them. A wrong Wolfram signature, a missing include or an undeclared static has passed all three and failed only the cross-build, five times now: `wf_display_facet`, a missing `<limits.h>` for `UINT_MAX`, `wf_agent_get_author_feed_typed`'s `filter` argument, `s_account` (a static that never existed; the agent's own handle comes from `wf_agent_get_handle`), and a missing `<wolfram/feed_gen_typed.h>` for `wf_feedgen_get_feed_generators_typed`. Run `make` for the console before calling a session change done;
- trusting `make warnings` to match the cross-build's diagnostics. The host
sweep compiles at `-O2` but the `make test` binary is `-O1`, and the ARM
`CFLAGS` carry no `-Werror`, so a value-range warning such as
Expand Down
Loading
Loading