Skip to content

chore: prep apps#3354

Merged
julienrbrt merged 1 commit into
mainfrom
julien/prep-113-2
Jun 12, 2026
Merged

chore: prep apps#3354
julienrbrt merged 1 commit into
mainfrom
julien/prep-113-2

Conversation

@julienrbrt

@julienrbrt julienrbrt commented Jun 12, 2026

Copy link
Copy Markdown
Member

Follow-up of #3353

Summary by CodeRabbit

  • Chores
    • Updated core dependency version from v1.1.2 to v1.1.3 across multiple application modules.
    • Removed local development module overrides in favor of released versions.

@claude

claude Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Claude finished @julienrbrt's task in 51s —— View job


Code Review

  • Gather context & read AGENTS.md
  • Review PR diff
  • Analyze dependency changes
  • Post findings

Summary

This is a clean, minimal maintenance PR that follows up on #3353 (the ev-node v1.1.3 release). The changes across all three app modules are consistent and correct:

  1. Disable local replace directives — The replace blocks pointing to local paths (../../) are commented out in all three go.mod files.
  2. Bump github.com/evstack/ev-node from v1.1.2v1.1.3 in all three apps.
  3. Update go.sum — New checksum entries for v1.1.3 and any transitive modules (execution/evm v1.0.1, execution/grpc v1.0.0) are properly added.

Observations

Minor style note — commented-out replace blocks

The replace directives are commented out rather than removed:

// replace (
//     github.com/evstack/ev-node => ../../
//     github.com/evstack/ev-node/execution/evm => ../../execution/evm
// )

This is a common and intentional convention in multi-module Go repos: it lets developers quickly uncomment for local development without needing to reconstruct the directive. As long as the team understands this pattern, it's fine. If it poses a risk of being accidentally committed (e.g., someone uncomments + forgets to re-comment before pushing), a Makefile/just target that toggles the mode would be safer — but that's a pre-existing concern, not introduced by this PR.

go.sum additions are correct — The new entries in each go.sum (h1: content hash + go.mod hash) match the expected pattern for the bumped module versions. No extraneous or missing entries were observed.

Consistency across modules — All three apps (evm, grpc, testapp) are updated uniformly. No module was missed or left on v1.1.2.


Verdict

No issues found. This PR is straightforward, consistent, and correct. LGTM.

@github-actions

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedJun 12, 2026, 10:39 AM

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dc152596-dc67-4dad-9696-613ca8f86018

📥 Commits

Reviewing files that changed from the base of the PR and between d208cd0 and c327a3b.

⛔ Files ignored due to path filters (3)
  • apps/evm/go.sum is excluded by !**/*.sum
  • apps/grpc/go.sum is excluded by !**/*.sum
  • apps/testapp/go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • apps/evm/go.mod
  • apps/grpc/go.mod
  • apps/testapp/go.mod

📝 Walkthrough

Walkthrough

The PR updates the github.com/evstack/ev-node module configuration across three applications. Local development overrides (replace directives pointing to relative paths) are commented out in apps/evm/go.mod, apps/grpc/go.mod, and apps/testapp/go.mod, while the required version is uniformly bumped from v1.1.2 to v1.1.3.

Changes

Module Resolution Update

Layer / File(s) Summary
Disable local replace overrides and bump ev-node to v1.1.3
apps/evm/go.mod, apps/grpc/go.mod, apps/testapp/go.mod
Replace directives for github.com/evstack/ev-node (and execution submodules in evm and grpc) are commented out, and the required version is updated from v1.1.2 to v1.1.3 across all three app modules.

Possibly related PRs

  • evstack/ev-node#3275: Identical pattern of commenting out local replace overrides and bumping ev-node version across apps/*/go.mod files.
  • evstack/ev-node#3353: Related to the preparation for the github.com/evstack/ev-node v1.1.3 release that this PR consumes.
  • evstack/ev-node#3276: Directly related at the module-resolution level; modifies the same replace directives in the same app go.mod files.

Suggested reviewers

  • tac0turtle
  • chatton

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A rabbit hops through modules with glee,
Replacing local paths with v1.1.3,
Three apps now unified in their way,
Published versions lead the day! 🎉

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only provides a link to a related PR without including required sections like Overview or explaining the rationale and goals of this changeset. Add an Overview section explaining why the local replace directives are being commented out and why the ev-node dependency is being updated to v1.1.3.
Title check ❓ Inconclusive The title is vague and generic, using 'prep apps' without specifying what preparation work is being done or which changes are being made. Make the title more specific, e.g., 'chore: update ev-node dependency to v1.1.3' or 'chore: update ev-node dependencies and remove local replace directives'.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch julien/prep-113-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.99%. Comparing base (d208cd0) to head (c327a3b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3354      +/-   ##
==========================================
+ Coverage   60.98%   60.99%   +0.01%     
==========================================
  Files         127      127              
  Lines       13879    13879              
==========================================
+ Hits         8464     8466       +2     
+ Misses       4491     4489       -2     
  Partials      924      924              
Flag Coverage Δ
combined 60.99% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julienrbrt julienrbrt merged commit 72c1d4f into main Jun 12, 2026
36 checks passed
@julienrbrt julienrbrt deleted the julien/prep-113-2 branch June 12, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants