Add Rank Tracking metric filters and fix null-last sort ordering#75
Merged
bensenescu merged 2 commits intoJul 13, 2026
Merged
Conversation
Contributor
|
Thanks for this, hope you join the discord! https://discord.com/invite/c9uGs3cFXr |
Contributor
Author
|
Thanks! Glad to contribute, and I'll definitely check out the Discord. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69
Changes
sortUndefined: "last"column option, which handles this independently of sort direction.RankTrackingFilters.tsxinto a UI component file and aRankTrackingFilters.logic.tsfile to stay under the project's file-length lint limit. The public import path (./RankTrackingFilters) is unchanged via a re-export, so no other files needed updates.Testing
pnpm ci:checkpasses locallypnpm testpasses locallyGreptile Summary
This PR adds metric filters and updates null-last sorting for rank tracking. The main changes are:
RankTrackingFilters.logic.tswhile preserving the existing import path.sortUndefined: "last"so missing values stay last in both sort directions.Confidence Score: 5/5
Safe to merge with low risk.
Changes are contained to client-side rank tracking filters, sorting accessors, and focused tests. No correctness, security, or behavioral coverage issues were identified in the changed paths.
No files require special attention.
What T-Rex did
Important Files Changed
sortUndefined: "last"for metric and position columns.Sequence Diagram
%%{init: {'theme': 'neutral'}}%% sequenceDiagram participant User participant FilterPanel participant Logic as RankTrackingFilters.logic participant Table as RankTrackingTable participant Columns as RankTrackingColumns User->>FilterPanel: Enter min/max metric filters FilterPanel->>Logic: Update Filters state Logic->>Logic: applyFilters(rows, filters) Logic-->>Table: Filtered rows User->>Columns: Toggle numeric column sort Columns-->>Table: Accessor value or undefined Table-->>User: Render sorted rows with undefined values last%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% sequenceDiagram participant User participant FilterPanel participant Logic as RankTrackingFilters.logic participant Table as RankTrackingTable participant Columns as RankTrackingColumns User->>FilterPanel: Enter min/max metric filters FilterPanel->>Logic: Update Filters state Logic->>Logic: applyFilters(rows, filters) Logic-->>Table: Filtered rows User->>Columns: Toggle numeric column sort Columns-->>Table: Accessor value or undefined Table-->>User: Render sorted rows with undefined values lastReviews (1): Last reviewed commit: "Merge branch 'every-app:main' into fix/r..." | Re-trigger Greptile