Skip to content

chore: remove dead code and reclassify test-only dependencies #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matt-evervault wants to merge 1 commit into
base: chore/migrate-to-pnpm-and-update-node
Choose a base branch
from
Open

chore: remove dead code and reclassify test-only dependencies #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sdk-cleanup-dead-code.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@evervault/sdk": patch
---

Remove unused internal modules (`labs`, `dataHelper`, `environment`) and their dead dependency reference (`big.js` was imported but never installed). Move test-only dependencies `crc-32` and `uuid` to `devDependencies`.
1 change: 0 additions & 1 deletion lib/core/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
module.exports = {
Crypto: require('./crypto'),
Http: require('./http'),
Labs: require('./labs'),
RelayOutboundConfig: require('./relayOutboundConfig'),
AttestationDoc: require('./attestationDoc'),
PcrManager: require('./pcrManager'),
Expand Down
12 changes: 0 additions & 12 deletions lib/core/labs.js
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions lib/core/labs/index.js
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions lib/utils/dataHelper.js
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions lib/utils/environment.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion lib/utils/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ module.exports = {
domainTargets: require('./domainTargets'),
errors: require('./errors'),
certHelper: require('./certHelper'),
environment: require('./environment'),
validationHelper: require('./validationHelper'),
httpsHelper: require('./httpsHelper'),
attest: require('./attest'),
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,13 @@
"agent-base": "^6.0.2",
"asn1js": "^3.0.5",
"async-retry": "^1.3.3",
"crc-32": "^1.2.2",
"uuid": "^8.1.0",
"axios": "^1.12.0"
},
"devDependencies": {
"@changesets/cli": "^2.29.2",
"chai": "^4.2.0",
"chai-as-promised": "^7.1.1",
"crc-32": "^1.2.2",
"husky": "^7.0.2",
"lint-staged": "^11.1.2",
"mocha": "^10.0.0",
Expand All @@ -63,7 +62,8 @@
"rewire": "^7.0.0",
"sinon": "^9.0.2",
"sinon-chai": "^3.5.0",
"typescript": "^5.3.3"
"typescript": "^5.3.3",
"uuid": "^8.1.0"
},
"release": {
"branches": [
Expand Down
20 changes: 10 additions & 10 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion tests/config.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ describe('Testing the Evervault SDK Config', () => {
afterEach(() => {
encryptStub.reset();
process.env.EV_API_URL = undefined;
process.env.EV_CAGE_RUN_URL = undefined;
process.env.EV_TUNNEL_HOSTNAME = undefined;
process.env.EV_CERT_HOSTNAME = undefined;
});
Expand Down