fix(reader): keep completed loading progress full#933
Merged
Conversation
Keep the reader loading ring filled after offline downloads reach completion and the loader moves into finalizing or preparation stages. Preserve spinner behavior for metadata fetches and unknown download progress, while keeping partial download progress unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This keeps the reader loading progress ring filled once an offline download has completed and the loader is finalizing or preparing reader resources. Unknown download progress and metadata fetches still use the spinner, while active downloads continue to show partial progress when available.
The branch also includes the requested build version bump to 503 as a separate commit.
Validation
make formatgit diff --checkgit diff --check origin/main...HEADmake build