refactor(storage): remove SwiftData legacy import#929
Merged
Conversation
Remove the SwiftData schema and legacy importer now that runtime storage is fully GRDB-backed. Startup now only opens and migrates the GRDB database, local data reset only tracks the active SQLite store, and AGENTS documents GRDB as the persistence layer. Add an append-only GRDB migration to drop the obsolete local migration marker table without mutating historical migrations.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfe3cf11c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes the remaining SwiftData-only compatibility path now that KMReader's runtime storage is GRDB-backed.
Startup no longer opens the legacy SwiftData store or runs the legacy importer. The obsolete versioned SwiftData schemas and migration plan are removed, local data reset only tracks the active GRDB SQLite files, and the contributor docs now describe GRDB as the persistence layer. The GRDB migrator keeps historical migrations immutable and adds a new append-only migration to drop the old local migration marker table.
This PR also includes the requested major version bump from 5.3 to 6.0, with build 500.
Validation
make formatgit diff --check origin/main...HEADmake build