Document the remaining 0.3 breaks in UPGRADING - #104
Merged
Conversation
The BC check against 0.2.4 reports 81 structural breaks; a few were not yet named in UPGRADING.md. The release policy requires every break to be recorded, so add the missing ones: - Type::some() removal (an identity function; point callers to Type::option()). - Parser\TypeHint and Parser\ParsedToken marked @internal. - Node-level plumbing marked @internal: Negative, AbstractLiteral, ListLiteral, LocationTrait, plus Negative's equals()/__toString() becoming final. Reconciles UPGRADING.md with the BC checker so 0.3.0 can be tagged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JVfG8L9ZctAtLCuXXZBQcP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconciles
UPGRADING.mdwith theroave/backward-compatibility-checkoutput ahead of tagging0.3.0.Running the BC check against
0.2.4reports 81 structural breaks. Most were already documented, but a handful were not yet named. Since the backward-compatibility policy requires every break to be recorded in the upgrade notes, this adds them:Type::some()removed — it was an identity function that returned its argument unchanged and never wrapped anything in anOption, despite the name. Callers who wanted an option type are pointed atType::option().Parser\TypeHintandParser\ParsedTokenmarked@internal— folded into the existing parser-members section.@internal— new section coveringNegative,AbstractLiteral,ListLiteral, andLocationTrait, plusNegative'sequals()/__toString()becomingfinal.After this lands,
RELEASING.mdstep 1 ("UPGRADING.md documents every break") and step 2 (reconcile the BC check) are satisfied and0.3.0can be tagged.🤖 Generated with Claude Code