Fixes cosmetic issue where the karma message target should match the … - #278
Open
jottinger wants to merge 2 commits into
Open
Fixes cosmetic issue where the karma message target should match the …#278jottinger wants to merge 2 commits into
jottinger wants to merge 2 commits into
Conversation
…requested target i.e., "~karma FoO" should say "FoO has karma 0" and not the normalized "foo has karma 0"
evanchooly
reviewed
May 27, 2020
| increment = false | ||
| } | ||
| var karma: Karma? = dao.find(nick) | ||
| var karma: Karma? = dao.find(nick.toLowerCase()) |
Owner
There was a problem hiding this comment.
this search is already case insensitive. it, in fact, upper cases the name before querying.
evanchooly
reviewed
May 27, 2020
| if (karma == null) { | ||
| karma = Karma() | ||
| karma.name = nick | ||
| karma.name = nick.toLowerCase() |
evanchooly
reviewed
May 27, 2020
| val nick = message.substring("karma ".length).toLowerCase() | ||
| val karma = dao.find(nick) | ||
| val nick = message.substring("karma ".length) | ||
| val normalizedNick=nick.toLowerCase() |
Owner
There was a problem hiding this comment.
ditto. the search already ignores case. lowercasing it is redundant. ( i know it was that way before but it was wrong then, too)
Owner
|
@dependabot recreate |
1 similar comment
Owner
|
@dependabot recreate |
Collaborator
Author
|
This has been updated, but I can't build it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…requested target
i.e., "~karma FoO" should say "FoO has karma 0" and not the normalized "foo has karma 0"