Skip to content

fix: preserve authorship label delete errors - #20

Merged
haasonsaas merged 1 commit into
mainfrom
codex/fix-authorship-delete-status
Apr 28, 2026
Merged

fix: preserve authorship label delete errors#20
haasonsaas merged 1 commit into
mainfrom
codex/fix-authorship-delete-status

Conversation

@haasonsaas

Copy link
Copy Markdown
Contributor

Summary

  • preserve the gh api DELETE exit status before handling absent-label 404s
  • keep non-404 label deletion failures from being silently swallowed

Verification

  • actionlint .github/workflows/agent-authorship-label.yml
  • ruby -c .github/scripts/classify-agent-authorship.rb

@cursor

cursor Bot commented Apr 28, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Low risk: small bash control-flow change in a GitHub Actions workflow to preserve gh api DELETE exit codes while still ignoring expected 404/not-found cases.

Overview
Fixes delete_label_if_present in agent-authorship-label to preserve the gh api --method DELETE exit status before checking for 404/not-found, ensuring unexpected label deletion failures are surfaced instead of being silently swallowed.

Reviewed by Cursor Bugbot for commit 63e7369. Bugbot is set up for automated code reviews on this repo. Configure here.

@haasonsaas
haasonsaas merged commit df06683 into main Apr 28, 2026
4 checks passed
@haasonsaas
haasonsaas deleted the codex/fix-authorship-delete-status branch April 28, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant