Skip to content

Allow explicit owned Wayland connections for deferred startup - #1

Open
thanosapollo wants to merge 1 commit into
eval-exec:patchfrom
thanosapollo:patch
Open

thanosapollo wants to merge 1 commit into
eval-exec:patchfrom
thanosapollo:patch

Conversation

@thanosapollo

Copy link
Copy Markdown

Dependency prerequisite for eval-exec/neomacs#454.

Deferred GUI attachment needs an explicit Wayland connection without changing process-wide display environment variables. Landing this change in the project fork also lets Neomacs stop depending on a personal fork.

Adds WaylandConnection and with_wayland_connection, creating a native event queue on the owned connection. Failed explicit initialization can retry; main-thread checks and the permanent successful-creation guard remain unchanged. Existing environment-based one-shot failure behavior is preserved. No new dependencies or vendoring.

This targets patch, the branch used by Neomacs. It adds one commit over 2290f91c602f8efdf102972457a25e8b6e36f90c: five files, +190/-5. NEOMACS_FORK.md names master, but targeting that branch would include six inherited X11/Windows commits outside this change.

Verification

  • Focused Wayland-only and default-feature tests: 3 passed, 1 opt-in ignored in each configuration.
  • Independent exact-tree correctness and maintainer-fit review: PASS / merge-worthy; 26 isolated native-compositor cases passed, including owned-connection lifetime, concurrent construction, failed-initialization retry and backend selection.
  • Clippy, X11-only check and scoped stable rustfmt passed. Documentation built with one existing activation-token link warning.
  • The contributor also reports human testing. This is runtime testing, not a claim of human code review.

Automated execution results are retained evidence for this unchanged reviewed tree, not new runs at submission. Nightly formatting, the full suite, MSRV, other targets and hosted CI remain unverified.

After acceptance into a project-owned ref, Neomacs can pin this fork's exact accepted revision. This dependency contribution does not itself close Neomacs rust-windowing#434.

An automated agent prepared and submitted this change; independent code review was also performed by an automated agent.

  • Tested on all platforms changed
  • Added a changelog entry
  • Documented the new platform-specific API
  • Added an example program

@coderabbitai

coderabbitai Bot commented Oct 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 18d6786e-f7ee-42bf-93ec-cfa4ad0bd7a8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant