Repository navigation
test: embed generated source in the archived transmute guard - #548
Closed
thanosapollo wants to merge 1 commit into
Closed
thanosapollo wants to merge 1 commit into
thanosapollo wants to merge 1 commit into
Conversation
Archived nextest shards do not retain the producer OUT_DIR. Embed x11_colors.rs at compile time and scan that source instead of reopening its build path. Keep the ceiling at six and reject unsupported includes. The pure upstream base passes four focused tests but its archived run fails on missing x11_colors.rs. The regression-first generated-source check fails before the walker correction; all six candidate controls pass directly and from the archive with producer build directories hidden. This changes test infrastructure only, not Lisp/GNU semantics.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No actionable merge risk is identified for this test-only change; it is ready for normal checks. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 28.57% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 1 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Description check The description clearly explains the archived test failure and the compile-time embedding fix. It also states the validation performed and the unchanged transmute ceiling. Title check The title concisely identifies the test change and the main implementation: embedding generated source in the archived transmute guard. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
eval-exec
added
the
status: needs-verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while investigating the archived core-test failure in main CI run 38017735406:
production_transmute_count_can_only_decreasetries to reopenx11_colors.rsin the producer'sOUT_DIR, which is absent on the shard runner.Embed that generated source at compile time and parse it through the existing walker. The ceiling remains six; generated code is still counted, ordinary includes are still read, and unsupported include forms still fail closed. No production or Lisp semantics change.
Tests against upstream base
baba54d9ae9b:Used nextest archive extraction and workspace remapping as in the shard workflow, with an unprivileged mount namespace hiding producer build directories. No generated assets borrowed from another worktree. This verifies the focused guard, not the full suite.
This PR is agent-assisted.