Repository navigation
ci: install nextest in the daemon-lifecycle job - #463
Conversation
The job now runs `cargo nextest run --locked -p neomacs --test
daemon_lifecycle`, but its setup-rust step never asked for nextest: the old
flow reached `cargo test` through `cargo xtask test-daemon-lifecycle`, which
needed no nextest at all. Without the install the job dies before building
anything:
error: no such command: `nextest`
##[error]Process completed with exit code 101
Every other nextest-using job in this workflow passes `install-nextest: true`;
this one now does too. Caught by the test-suite run for main 37115597587
(job 111181701603).
That run's `workspace test archive` failure is unrelated: a compile error in
b845d16 ("test(gc): generational verifier and stress"),
`error[E0599] no method named debug_assert_remembered_membership` at
crates/neovm-core/src/tagged/gc/tests/generational_tests.rs:86.
The same run's build log confirms the new generation path works on the
runner -- "regenerated lisp/international/cp51932.el from cp51932.awk (GNU
admin/charsets/Makefile.in:213-214)", and the same for eucjp-ms.el.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe daemon lifecycle job now enables nextest installation in its Rust tooling setup. ChangesDaemon lifecycle testing
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The daemon-lifecycle job now installs nextest before running its test, addressing the reported missing-command failure. No actionable merge-blocking risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The one-line change correctly adds the valid install-nextest: true input needed by the job's cargo nextest run invocation, matching the established pattern used by other nextest jobs.
Review effort: Balanced
Findings: None
What changed in this PR
This PR fixes a broken CI job. The daemon lifecycle (linux, matching debug runtime) job in test-suite.yml runs cargo nextest run (line 104), but its setup-rust step never requested nextest installation after #451 switched the job from cargo xtask test-daemon-lifecycle (plain cargo test) to cargo nextest. This caused the job to fail with error: no such command: nextest. The fix adds install-nextest: true to the step's inputs, consistent with every other nextest-using job in the workflow.
Changes:
- Add
install-nextest: trueto the daemon-lifecycle job'ssetup-ruststep so thecargo nextest runinvocation has the required binary.
| File | Description |
|---|---|
| .github/workflows/test-suite.yml | Adds install-nextest: true input to the daemon-lifecycle job's setup-rust step so nextest is installed before cargo nextest run. |
I verified that install-nextest is a valid input of the setup-rust composite action (.github/actions/setup-rust/action.yml:44-47, which gates a cargo-nextest install at lines 77-81), that the job indeed invokes cargo nextest run at line 104, that the added line's indentation matches the sibling with: keys (lines 91-93), and that the sibling Windows nextest job uses the same install-nextest: true pattern (line 131). No issues were found.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The daemon-lifecycle job began running
cargo nextest run --locked -p neomacs --test daemon_lifecyclein #451, but itssetup-ruststep never asked for nextest — the previous flow reached plaincargo testthroughcargo xtask test-daemon-lifecycle, so the job never needed it. The result on main (run 37115597587, job 111181701603):The job died before building anything. Every other nextest-using job in this workflow passes
install-nextest: true; this adds it.Verified in the same run's build log that the rest of the new flow works on the runner:
Unrelated red on the same run:
workspace test archivefails to compilecrates/neovm-core/src/tagged/gc/tests/generational_tests.rs:86—error[E0599] no method named debug_assert_remembered_membership found for struct gc::TaggedHeap— introduced by b845d16 ("test(gc): generational verifier and stress"). That is not touched here; this PR's own checks will show it until that commit is fixed.