PostgreSQL 19 fixes - #45
Open
devrimgunduz wants to merge 1 commit into
Open
Conversation
replace `bits8 *pa, *pb` with `uint8 *pa, *pb` in hamming(). PG19 dropped the `bits8` typedef (previously `typedef uint8 bits8;` in c.h) in favor of using `uint8` directly; VARBITS() now returns `uint8 *` instead of `bits8 *`. Under PG18 and earlier this compiled fine because `bits8` was a valid alias, but on PG19 the identifier is gone entirely, so the compiler treats `bits8 *pa, *pb;` as an expression rather than a declaration, producing "use of undeclared identifier 'bits8'" (clang) / "unknown type name 'bits8'" (gcc), plus the cascading "undeclared identifier pa/pb" and "assignment ... from incompatible pointer type 'uint8 *'" errors Hacked by Claude, tested by me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R eplace
bits8 *pa, *pbwithuint8 *pa, *pbin hamming(). PG19 dropped thebits8typedef (previouslytypedef uint8 bits8;in c.h) in favor of usinguint8directly; VARBITS() now returnsuint8 *instead ofbits8 *. Under PG18 and earlier this compiled fine becausebits8was a valid alias, but on PG19 the identifier is gone entirely, so the compiler treatsbits8 *pa, *pb;as an expression rather than a declaration, producing "use of undeclared identifier 'bits8'" (clang) / "unknown type name 'bits8'" (gcc), plus the cascading "undeclared identifier pa/pb" and "assignment ... from incompatible pointer type 'uint8 *'" errors.Hacked by Claude, tested by me.
Per: pgdg-packaging/pgdg-rpms#213