build-and-copy.sh: --vllm-source-dir no longer disables B12x - #370
Open
nicjansma wants to merge 1 commit into
Open
build-and-copy.sh: --vllm-source-dir no longer disables B12x#370nicjansma wants to merge 1 commit into
nicjansma wants to merge 1 commit into
Conversation
…Adds --with-b12x option to force B12; --vllm-version-anchor option added (#1) * build-and-copy.sh: --vllm-version-anchor option added * --vllm-source-dir no longer disables B12x; Adds --with-b12x * build-and-copy.sh: need to pin B12X to 1.2.6 as master is ahead * Remove version anchor stuff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #363: A recent source checkout of vLLM 0.28.0+ (or https://github.com/local-inference-lab/vllm) won't complile all of the necessary B12X components for e.g. DS4F.
After investigating, vLLM 0.28.x doesn't (yet) have all of the local-inference-lab changes from @lukealonso merged in for B12X, i.e. vllm-project/vllm#52017, so the dual Spark DS4F recipe doesn't work.
local-inference-lab is very close to 0.28.x, including some fixes I wanted for DS4F stability, so I switched to building off that. However, that tree was failing builds as well since there were some changes with upstream b12x packages.
Changes
build-and-copy.shchanges:--vllm-source-dirno longer disables B12x--with-b12xoption to force B12xFixes
prepare_local_vllm_source()setsVLLM_REPO="local-source", which the B12X eligibility gate compares against two literal URLs - so a local clone of upstream vLLM never got the B12X kernel package, and--linear-backend b12xfailed at runtime withFailed to find a kernel that can implement the ScaledMM linear layer.The metadata recorded only
b12x_repo: "disabled".The gate now falls back to the checkout's origin remote, compared via a new
normalize_git_url()that matcheshttps,ssh, andgit@spellings.--with-b12xforces the package in for mirrors, forks, and checkouts without an origin. An unrecognised checkout now warns explicitly instead of failing silently at serve time.Results
This build command now works:
AI Disclosure
This PR was investigated, codified and verified by an AI agent. I have manually reviewed, verified and tweaked the output.