Cleaner artifact generation#25
Open
etpinard wants to merge 4 commits into
Open
Conversation
using `Pkg.Artifacts` functions
... we'll try to do this in julia
Collaborator
|
This looks great, we're better of using this one julia script than We could do a patch release after the holidays to use it 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inspired by https://github.com/sglyon/PlotlyBase.jl/blob/master/deps/generate_artifacts.jl so that we now use the following official methods exported from
Pkg.Artifacts:create_artifactsarchive_artifact(which creates a new tarball and should work across platforms, unliketar)bind_artifact!(which writes theArtifact.tomlcontent)Moreover, I think we'll be able to remove
dash-textarea-autocomplete/.github/workflows/tests.yml
Lines 43 to 52 in 8731437
that is,
Pkg.add(url=\"$GITHUB_SERVER_URL/$GITHUB_REPOSITORY\", rev=\"$GITHUB_SHA\");should just work now.Oh well, we don't need to merge this PR and maybe we shouldn't for now.
@Felix-Gauthier I think we have spent enough time on
dash-textarea-autocompletein the last 10 days or so. Consider this PR documentation for futuredash-textarea-autocompletework.