Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@
^\.github$
^cran-comments\.md$
^CRAN-SUBMISSION$

^jarl\.toml$
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: flir
Type: Package
Title: Find and Fix Lints in R Code
Version: 0.5.0.9000
Version: 0.6.0
Authors@R:
c(person(given = "Etienne",
family = "Bacher",
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# flir (development version)
# flir 0.6.0

## New features

Expand Down
2 changes: 1 addition & 1 deletion R/utils.R
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ get_tests_from_lintr <- function(name) {
"_linter.R"
)
dest <- paste0("tests/testthat/test-", name, ".R")
utils::download.file(url, destfile = dest)
utils::download.file(url, destfile = dest, mode = "wb")
if (rlang::is_interactive()) {
utils::file.edit(dest)
}
Expand Down
14 changes: 0 additions & 14 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,14 +0,0 @@
This is the first CRAN release (3rd try).

Thank you for the comments, I have updated the functions that write to the user
file system so that the argument `path` has to be specified. Note that in tests
only (which don't write to the working directory), a missing `path` means that
`"."` is used by default.

While I understand the willingness to minimize automatic changes to the user's
file system, I must say there's quite a discrepancy in how this policy is
applied. Many CRAN packages (including some of my own) directly write to the user
file system without asking for user confirmation such as `altdoc`, `devtools`,
`pkgdown`, `rextendr`, `Rcpp`, `roxygen2`, etc. Therefore, from the package
developer's point of view, it's hard to understand why this usage is accepted
for some packages but not others.
7 changes: 4 additions & 3 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ Bundock
CMD
Github
Jagan
Jarl
Linters
Mikael
ORCID
RStudio
YAML
ast
astgrepr
coercions
config
fleer
formatter
grepl
Expand All @@ -20,8 +20,9 @@ lapply
len
linter
linters
lintr
nlevels
repo
nzchar
sourceMarkers
stopifnot
unstaged
Expand Down