Skip to content

Round the arrival timeline axis labels to whole milliseconds - #853

Merged
samcm merged 1 commit into
masterfrom
fix/arrival-axis-label
Aug 27, 2026
Merged

Round the arrival timeline axis labels to whole milliseconds#853
samcm merged 1 commit into
masterfrom
fix/arrival-axis-label

Conversation

@samcm

@samcm samcm commented Aug 27, 2026

Copy link
Copy Markdown
Member

The timeline axis bounds are computed as fractions of the observation spread, so the left label could render float noise like 220.64999999999998ms. fmtAxis now rounds to whole milliseconds before formatting.

https://claude.ai/code/session_01QTfZjLgwhNK5i4At7BfrBR

@redpandabot redpandabot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR rounds axis label values to whole milliseconds in fmtAxis before formatting, fixing float-noise labels like 220.64999999999998ms on the timeline axis bounds. The change is display-only: all four fmtAxis call sites feed axis geometry or whole-number steps, pos()/span are untouched, inputs are always non-negative (no -0 edge), and rounding can only shorten labels, which strictly helps the axisHeader label-overlap heuristics.


Reviewed 1 changed file(s) @ f7472e61 — no blocking issues found.
"A user interface is like a joke. If you have to explain it, it's not that good."

@samcm
samcm enabled auto-merge August 27, 2026 02:11
@samcm
samcm merged commit 7174f49 into master Aug 27, 2026
2 checks passed
@samcm
samcm deleted the fix/arrival-axis-label branch August 27, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants