Link the builder payload icon to the builder page and show builder names - #852
Merged
Merged
Conversation
The hard-hat build-source icon next to the proposer linked out to the buildoor's external API URL whenever the inventory knew it, and its tooltip only ever printed the raw builder index. It now always links to the internal /builder/<index> page and names the builder in the tooltip when known. The dedicated Builder column also dropped the builder name whenever an external URL was known, collapsing to the bare index. It now keeps the name and only surfaces the URL on hover. The local devnet script now detects per-participant buildoor instances (buildoor-<cl>-<el>-<n>) so their names resolve in dora.
SummaryThe PR links the builder-built proposer icon to /builder/, adds the builder name to its tooltip, and preserves the builder name in the Builder column (URL only on hover), plumbing builder_name through the index page models, handler, templates, and the JS twin. The Pl/JS/template/model changes are consistent and correctly escaped; I found no blockers, only a hedged concern about the devnet buildoor container-discovery filter and a stale JS parameter name in the knockout wrapper. Issues
Reviewed @ |
pk910
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Gloas devnets the hard-hat "builder-built payload" icon next to the proposer linked out to the buildoor's external API URL (
target="_blank") whenever the buildoor inventory knew it, instead of the builder details page. Its tooltip also only ever printed the raw builder index (builder 10045) even when the inventory had a name for it.The dedicated Builder column had the inverse problem: whenever an external URL was known it dropped the builder name and collapsed to the bare index.
Changes
FormatProposerWithBuildSource(+ its JS twin inpage-index.js) always links the icon to/builder/<index>and names the builder in the tooltip when known:Builder-built payload by <name> (<index>).builder_nameadded to the index JSON models) and the templates pass it through.formatBuilderkeeps the builder name when an external URL is known and only shows the URL on hover..hack/devnet/run.shnow detects per-participant buildoor instances (buildoor-<cl>-<el>-<n>, from ethereum-packagebuildoor_params.instances), so local devnets resolve builder names.Screenshots (local kurtosis devnet, gloas at epoch 1, one buildoor)
Proposer column — icon now links to
/builder/0, tooltip names the builder:Builder column — name shown inline, buildoor URL only on hover:
Index page (knockout-rendered rows):